r185873 - [Objective-C migrator] replace candidate user setter/getter with

[Jean-Daniel Dupas]

Le 10 juil. 2013 à 02:24, jahanian <fjahanian at apple.com> a écrit :

> 
> On Jul 9, 2013, at 9:22 AM, Jordan Rose <jordan_rose at apple.com> wrote:
> 
>> 
>> On Jul 8, 2013, at 14:42 , Fariborz Jahanian <fjahanian at apple.com> wrote:
>> 
>>> + at property(weak) NSString *__weak WeakProp;
>>> +
>>> + at property(strong) NSString * StrongProp;
>> 
>> Conventionally, I'd expect the __weak to disappear and the "strong" to be implied instead of explicitly spelled out.
> 
> __weak came from user code. migration did not generate it. removed “strong” from migrated attributes.
> 
>> 
>> I hope inferring "(copy)" is in the works. Plenty of value object properties (NSString, NSURL, etc.) are copy properties.
> 
> I am now producing “copy” for all retainable object types whose life time is “strong". I am not sure if there is more precise 
> rule for this though?

I think it should make sure the class conforms to NSCopying.

-- Jean-Daniel




-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20130710/001c73be/attachment.html>