[libcxx] r185950 - Bill Fisher: This patch fixes a bug where regex_iterator doesn't indicate when it's restarting in the middle of a string. This bug causes /^a/ to match in the middle of the string "aaaaaaa", during iteration.
Howard Hinnant
hhinnant at apple.com
Tue Jul 9 10:29:09 PDT 2013
Author: hhinnant
Date: Tue Jul 9 12:29:09 2013
New Revision: 185950
URL: http://llvm.org/viewvc/llvm-project?rev=185950&view=rev
Log:
Bill Fisher: This patch fixes a bug where regex_iterator doesn't indicate when it's restarting in the middle of a string. This bug causes /^a/ to match in the middle of the string "aaaaaaa", during iteration.
My patch uses to communicate when is false.
Added:
libcxx/trunk/test/re/re.alg/re.alg.search/no_update_pos.pass.cpp
Modified:
libcxx/trunk/include/regex
Modified: libcxx/trunk/include/regex
URL: http://llvm.org/viewvc/llvm-project/libcxx/trunk/include/regex?rev=185950&r1=185949&r2=185950&view=diff
==============================================================================
--- libcxx/trunk/include/regex (original)
+++ libcxx/trunk/include/regex Tue Jul 9 12:29:09 2013
@@ -5773,7 +5773,8 @@ basic_regex<_CharT, _Traits>::__search(
{
__m.__init(1 + mark_count(), __first, __last,
__flags & regex_constants::__no_update_pos);
- if (__match_at_start(__first, __last, __m, __flags, true))
+ if (__match_at_start(__first, __last, __m, __flags,
+ !(__flags & regex_constants::__no_update_pos)))
{
__m.__prefix_.second = __m[0].first;
__m.__prefix_.matched = __m.__prefix_.first != __m.__prefix_.second;
Added: libcxx/trunk/test/re/re.alg/re.alg.search/no_update_pos.pass.cpp
URL: http://llvm.org/viewvc/llvm-project/libcxx/trunk/test/re/re.alg/re.alg.search/no_update_pos.pass.cpp?rev=185950&view=auto
==============================================================================
--- libcxx/trunk/test/re/re.alg/re.alg.search/no_update_pos.pass.cpp (added)
+++ libcxx/trunk/test/re/re.alg/re.alg.search/no_update_pos.pass.cpp Tue Jul 9 12:29:09 2013
@@ -0,0 +1,38 @@
+//===----------------------------------------------------------------------===//
+//
+// The LLVM Compiler Infrastructure
+//
+// This file is dual licensed under the MIT and the University of Illinois Open
+// Source Licenses. See LICENSE.TXT for details.
+//
+//===----------------------------------------------------------------------===//
+
+// <regex>
+
+// template <class BidirectionalIterator, class Allocator, class charT, class traits>
+// bool
+// regex_search(BidirectionalIterator first, BidirectionalIterator last,
+// match_results<BidirectionalIterator, Allocator>& m,
+// const basic_regex<charT, traits>& e,
+// regex_constants::match_flag_type flags = regex_constants::match_default);
+
+#include <regex>
+#include <cassert>
+
+int main()
+{
+ // Iterating over /^a/ should yield one instance at the beginning
+ // of the text.
+
+ const char *text = "aaa\naa";
+ std::regex re{"^a"};
+ std::cregex_iterator it{text, text+6, re};
+ std::cregex_iterator end{};
+
+ assert(it->str() == "a");
+ assert(it->position(0) == 0);
+ assert(it->length(0) == 1);
+
+ ++it;
+ assert(it == end);
+}
More information about the cfe-commits
mailing list