r185773 - Fixed source range for functional cast and unresolved construct expr nodes.

Enea Zaffanella zaffanella at cs.unipr.it
Mon Jul 8 03:50:45 PDT 2013


On 07/08/2013 10:48 AM, Enea Zaffanella wrote:
> On 07/08/2013 08:59 AM, NAKAMURA Takumi wrote:
>> Enea,
>>
>> It was incompatible to ms mode. I made it suppressed partially in
>> r185795.
>>
>> clang\unittests\AST\SourceLocationTest.cpp(222):
>> error: Value of: Verifier.match( "template <typename U>\n" "U foo()
>> {\n" "  return U{};\n" "}", unresolvedConstructExpr(), Lang_CXX11)
>>    Actual: false (Could not find match)
>> Expected: true
>> [  FAILED  ] CXXUnresolvedConstructExpr.SourceRange (4 ms)
>>
>> Do you think it'd be better to add "-fno-delayed-template-parsing" there?

[...]

> Or maybe add an overloaded version with such an additional parameter?

Would the attached patch be OK?
(Note: made no test at all on windows).

Enea.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: args.patch
Type: text/x-diff
Size: 2889 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20130708/63abebb2/attachment.patch>


More information about the cfe-commits mailing list