[PATCH] Add full semantic support for dllimport/export attributes

Eli Friedman eli.friedman at gmail.com
Sat Jul 6 14:18:05 PDT 2013


On Sat, Jul 6, 2013 at 12:34 PM, Eli Friedman <eli.friedman at gmail.com> wrote:
> @@ -259,9 +259,9 @@
>        if (Triple.getOS() == llvm::Triple::Win32 ||
>            Triple.getOS() == llvm::Triple::MinGW32) {
>          switch (Attr.getKind()) {
> -        case AttributeList::AT_DLLImport: HandleDLLImportAttr(D, Attr, S);
> +        case AttributeList::AT_DLLImport: handleDLLImportAttr(D, Attr, S);
>                                            return true;
> -        case AttributeList::AT_DLLExport: HandleDLLExportAttr(D, Attr, S);
> +        case AttributeList::AT_DLLExport: handleDLLExportAttr(D, Attr, S);
>                                            return true;
>          default:                          break;
>          }
>
> This doesn't look like it's actually a change.  If there's something
> weird going on with whitespace, please commit separately.

Oh, sorry, didn't spot that the case of the "H" changed.  Still, it's
a good idea to keep your patches smaller if possible.

-Eli



More information about the cfe-commits mailing list