r185608 - [analyzer] Make sure that inlined defensive checks work on div by zero.

Jordan Rose jordan_rose at apple.com
Wed Jul 3 21:51:56 PDT 2013


Looks good. One comment:

On Jul 3, 2013, at 19:38 , Anna Zaks <ganna at apple.com> wrote:

> +    if (V.isUndef() ||
> +        V.getAs<loc::ConcreteInt>() || V.getAs<nonloc::ConcreteInt>()) {

We have a short way of writing this: V.isConstant().

Jordan
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20130703/fe026bc9/attachment.html>


More information about the cfe-commits mailing list