[PATCH] [ms-cxxabi] Mangle variadic template parameter packs

[Timur Iskhodzhanov]

  LGTM with nits


================
Comment at: lib/AST/MicrosoftMangle.cpp:137
@@ -136,3 +136,3 @@
                           const TemplateArgumentList &TemplateArgs);
-
+  void mangleTemplateArg(const TemplateDecl *TD, const TemplateArgument &TA, int i);
 };
----------------
Can you come up with a more descriptive name?
e.g. OrdinalNumber?

================
Comment at: lib/AST/MicrosoftMangle.cpp:878
@@ +877,3 @@
+  case TemplateArgument::Pack:
+    // MSVC 2013 is the first version to support variadic templates, and it
+    // doesn't do anything special to mangle template parameter packs.
----------------
I think it's safe to remove this comment

================
Comment at: test/CodeGenCXX/mangle-ms-templates.cpp:137
@@ +136,3 @@
+
+// MSVC 2013 doesn't do anything special to mangle variadic template parameter
+// packs.
----------------
ditto


http://llvm-reviews.chandlerc.com/D1077

BRANCH
  variadic-templates

ARCANIST PROJECT
  clang