r185300 - Use static for helper functions instead of an anonymous namespace per coding standards.

Craig Topper craig.topper at gmail.com
Sun Jun 30 20:38:29 PDT 2013


Author: ctopper
Date: Sun Jun 30 22:38:29 2013
New Revision: 185300

URL: http://llvm.org/viewvc/llvm-project?rev=185300&view=rev
Log:
Use static for helper functions instead of an anonymous namespace per coding standards.

Modified:
    cfe/trunk/lib/Format/BreakableToken.cpp

Modified: cfe/trunk/lib/Format/BreakableToken.cpp
URL: http://llvm.org/viewvc/llvm-project/cfe/trunk/lib/Format/BreakableToken.cpp?rev=185300&r1=185299&r2=185300&view=diff
==============================================================================
--- cfe/trunk/lib/Format/BreakableToken.cpp (original)
+++ cfe/trunk/lib/Format/BreakableToken.cpp Sun Jun 30 22:38:29 2013
@@ -24,7 +24,6 @@
 
 namespace clang {
 namespace format {
-namespace {
 
 static const char *const Blanks = " \t\v\f";
 static bool IsBlank(char C) {
@@ -39,10 +38,10 @@ static bool IsBlank(char C) {
   }
 }
 
-BreakableToken::Split getCommentSplit(StringRef Text,
-                                      unsigned ContentStartColumn,
-                                      unsigned ColumnLimit,
-                                      encoding::Encoding Encoding) {
+static BreakableToken::Split getCommentSplit(StringRef Text,
+                                             unsigned ContentStartColumn,
+                                             unsigned ColumnLimit,
+                                             encoding::Encoding Encoding) {
   if (ColumnLimit <= ContentStartColumn + 1)
     return BreakableToken::Split(StringRef::npos, 0);
 
@@ -76,10 +75,10 @@ BreakableToken::Split getCommentSplit(St
   return BreakableToken::Split(StringRef::npos, 0);
 }
 
-BreakableToken::Split getStringSplit(StringRef Text,
-                                     unsigned ContentStartColumn,
-                                     unsigned ColumnLimit,
-                                     encoding::Encoding Encoding) {
+static BreakableToken::Split getStringSplit(StringRef Text,
+                                            unsigned ContentStartColumn,
+                                            unsigned ColumnLimit,
+                                            encoding::Encoding Encoding) {
   // FIXME: Reduce unit test case.
   if (Text.empty())
     return BreakableToken::Split(StringRef::npos, 0);
@@ -127,8 +126,6 @@ BreakableToken::Split getStringSplit(Str
   return BreakableToken::Split(StringRef::npos, 0);
 }
 
-} // namespace
-
 unsigned BreakableSingleLineToken::getLineCount() const { return 1; }
 
 unsigned BreakableSingleLineToken::getLineLengthAfterSplit(





More information about the cfe-commits mailing list