[PATCH] PR12463 : Warnings about nonsensical comparisons are disabled if macro expansion is involved

[Eli Friedman]

On Sat, Jun 29, 2013 at 11:23 PM, Lubos Lunak <l.lunak at suse.cz> wrote:

>
>  Hello,
>
>  could somebody please review and commit the atached patch for pr12463?
> Thank
> you.
>
> +    bool InMacro = LHS.get()->getLocStart().isMacroID() ||
+                   RHS.get()->getLocStart().isMacroID();

Why not just check the source location of the operator itself?  It seems
like we want to diagnose "MYMACRO1 == MYMACRO2".

-Eli
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20130630/2cecb3b9/attachment.html>