[PATCH] Make RecursiveASTVisitor::TraverseLambdaExpr call WalkUpFromLambdaExpr

James Dennett jdennett at google.com
Fri Jun 28 13:57:42 PDT 2013


On Fri, Jun 28, 2013 at 1:10 AM, James Dennett <jdennett at google.com> wrote:
> I believe that there's a bug in
> RecursiveASTVisitor::TraverseLambdaExpr, in that it fails to actually
> call the Visit* functions on the LambdaExpr itself, while the
> documentation (and desired behavior) says that TraverseFoo(x) should
> call WalkUpFromFoo(x) and then recursively visit x's children.
>
> This patch adds in the obvious call to WalkUpFromLambdaExpr, and a
> test (that fails with the current RecursiveASTVisitor and passes with
> the fixed version).
>
> The test depends on a previous patch I've just sent for review ("Allow
> TestVisitor-based tests to specify use of C++11").
>
> Please take a look.

Either here or at http://llvm-reviews.chandlerc.com/D1062.

-- James



More information about the cfe-commits mailing list