r185159 - Fix a trivial typo, add a FIXME to have more test coverage for VTableBuilder

Timur Iskhodzhanov timurrrr at google.com
Fri Jun 28 08:42:28 PDT 2013


Author: timurrrr
Date: Fri Jun 28 10:42:28 2013
New Revision: 185159

URL: http://llvm.org/viewvc/llvm-project?rev=185159&view=rev
Log:
Fix a trivial typo, add a FIXME to have more test coverage for VTableBuilder

Modified:
    cfe/trunk/lib/AST/VTableBuilder.cpp

Modified: cfe/trunk/lib/AST/VTableBuilder.cpp
URL: http://llvm.org/viewvc/llvm-project/cfe/trunk/lib/AST/VTableBuilder.cpp?rev=185159&r1=185158&r2=185159&view=diff
==============================================================================
--- cfe/trunk/lib/AST/VTableBuilder.cpp (original)
+++ cfe/trunk/lib/AST/VTableBuilder.cpp Fri Jun 28 10:42:28 2013
@@ -1914,6 +1914,8 @@ VTableBuilder::LayoutVTablesForVirtualBa
 
 /// dumpLayout - Dump the vtable layout.
 void VTableBuilder::dumpLayout(raw_ostream& Out) {
+  // FIXME: write more tests that actually use the dumpLayout output to prevent
+  // VTableBuilder regressions.
 
   if (isBuildingConstructorVTable()) {
     Out << "Construction vtable for ('";
@@ -2166,7 +2168,7 @@ void VTableBuilder::dumpLayout(raw_ostre
         
         // If this function pointer has a return pointer adjustment, dump it.
         if (!Thunk.Return.isEmpty()) {
-          Out << "return adjustment: " << Thunk.This.NonVirtual;
+          Out << "return adjustment: " << Thunk.Return.NonVirtual;
           Out << " non-virtual";
           if (Thunk.Return.VBaseOffsetOffset) {
             Out << ", " << Thunk.Return.VBaseOffsetOffset;





More information about the cfe-commits mailing list