[PATCH] [ms-cxxabi] Move CodeGenVTables::needsVTTParameter to ItaniumCXXABI.

John McCall rjmccall at apple.com
Thu Jun 27 10:20:28 PDT 2013


On Jun 27, 2013, at 9:46 AM, Reid Kleckner <rnk at google.com> wrote:
> Now that vbtables are implemented, I can say that the needsVTT predicate doesn't affect vbtable generation at all.  vbtables get installed by EmitCtorCompleteObjectHandler().
> 
> John, I think Timur is working on a larger refactoring of VTableBuilder and maybe CGVTables.  This patch as is helps avoid asserts and adds a test case for it so we won't regress during the refactor, so I'd like to go forward with it.

Sure, it's fine.

John.



More information about the cfe-commits mailing list