[libclc] r184998 - Add a TODO note.

Tom Stellard thomas.stellard at amd.com
Wed Jun 26 11:21:22 PDT 2013


Author: tstellar
Date: Wed Jun 26 13:21:22 2013
New Revision: 184998

URL: http://llvm.org/viewvc/llvm-project?rev=184998&view=rev
Log:
Add a TODO note.

Patch by: Aaron Watry

Modified:
    libclc/trunk/generic/lib/integer/rotate.inc

Modified: libclc/trunk/generic/lib/integer/rotate.inc
URL: http://llvm.org/viewvc/llvm-project/libclc/trunk/generic/lib/integer/rotate.inc?rev=184998&r1=184997&r2=184998&view=diff
==============================================================================
--- libclc/trunk/generic/lib/integer/rotate.inc (original)
+++ libclc/trunk/generic/lib/integer/rotate.inc Wed Jun 26 13:21:22 2013
@@ -21,6 +21,10 @@ _CLC_OVERLOAD _CLC_DEF GENTYPE rotate(GE
         return ( (((UGENTYPE)x) >> -n) | (x << (GENSIZE + n)) );
     }
 #else
+    //XXX: There's a lot of __builtin_astype calls to cast everything to
+    //     unsigned ... This should be improved so that if GENTYPE==UGENTYPE, no
+    //     casts are required.
+    
     UGENTYPE x_1 = __builtin_astype(x, UGENTYPE);
 
     UGENTYPE amt;





More information about the cfe-commits mailing list