[PATCH] [PATCH] Add armv8 support to the Clang driver.

Tim Northover t.p.northover at gmail.com
Wed Jun 26 04:57:12 PDT 2013


Hi Joey,

I think the patch is mostly fine, but this looks a little odd:

> +// RUN: %clang -target armv7a-unknown-linux-gnueabi -S -emit-llvm %s -o - | FileCheck %s --check-prefix=V7
> [...]
> +// CHECK-V7: target triple = "armv7-unknown-linux-gnueabi"

I thought that FileCheck line means it'll look for "V7:"? I expect
it's ignoring the "CHECK-" and finding it anyway, but the examples
I've seen elsewhere either keep or drop the "CHECK-" everywhere.

Tim.



More information about the cfe-commits mailing list