[PATCH] Add noinline attribute to sanitizer-blacklisted functions

[Chandler Carruth]

On Tue, Jun 25, 2013 at 1:36 AM, Kostya Serebryany <kcc at google.com> wrote:

>   I don't like that one attribute implies another attribute silently, but
> I see no other good way to fix the issue.
>   At the very least we need to update the docs in this change.
>   Also let's wait for a day if anyone has a better idea.
>

I really share your feelings here.

Fundamentally, I don't think 'noinline' is what you want here. It has all
kinds of implications you don't really intend.

For example, if you have one blacklisted function calling another, you can
inline freely.

How about teaching the inliner specifically to not inline functions with
the attributes you care about into functions which don't have them (or vice
versa)?
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20130625/a1ff6772/attachment.html>