[PATCH] [AST] Introduce a new DecayedType sugar node
Reid Kleckner
rnk at google.com
Mon Jun 24 10:33:00 PDT 2013
Thanks for the review! Will commit with fixes for the remaining comments.
================
Comment at: lib/StaticAnalyzer/Checkers/CheckSecuritySyntaxOnly.cpp:310
@@ -309,3 +309,3 @@
// Is the argument a 'char*'?
- const PointerType *PT = dyn_cast<PointerType>(FPT->getArgType(0));
+ const PointerType *PT = FPT->getArgType(0)->getAs<PointerType>();
if (!PT)
----------------
Richard Smith wrote:
> There's a bunch more of these elsewhere in the file. Please commit these fixes separately.
Do you mean I need to look for more, or just that there are many changes, and therefore I should commit them separate from the rest of DecayedType? I went ahead and committed the current checker changes as is in r184755.
http://llvm-reviews.chandlerc.com/D1014
More information about the cfe-commits
mailing list