[patch] Correctly classifying PackExpansionType as NON_CANONICAL_UNLESS_DEPENDENT

David Blaikie dblaikie at gmail.com
Fri Jun 21 13:45:34 PDT 2013


Hi Richard,

>From our conversation/your help this morning, here's a patch that at
least solves my original problem (Type::getAs<TagDecl> on a RecordDecl
of a non-dependent alias template).

Does this look about right? This doesn't address the further
simplification of getTypeInfoImpl that we were discussing, but I
expect that can be handled before/after (happy to do it, though, if
you would like me to have a go at it). Are there some test cases I
should add? (I don't know the code well enough to know if this
manifests in any real way, I assume it does though)

Thanks,
- David
-------------- next part --------------
A non-text attachment was scrubbed...
Name: pack_dependent.diff
Type: application/octet-stream
Size: 4310 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20130621/44be05a0/attachment.obj>


More information about the cfe-commits mailing list