r184559 - Add basic fixit test to template instantiation bug fix (r184503)

[Larisse Voufo]

Thanks. It turns out I do not need FileCheck, nor grep afterall. cf.
r184577.



On Fri, Jun 21, 2013 at 9:57 AM, David Blaikie <dblaikie at gmail.com> wrote:

> On Fri, Jun 21, 2013 at 9:51 AM, Larisse Voufo <lvoufo at google.com> wrote:
> > Ok. test/CXX/FixIt/typo.cpp uses grep too, just fyi for what it's worth.
>
> Yep, there's lots of legacy in LLVM (you'll notice the inconsistent
> naming conventions, for example - we have a naming standard, but some
> names are from a prior standard & no one's cleaned them up) but we
> generally have current plans of where we're trying to move the
> codebase.
>
> http://llvm.org/docs/TestingGuide.html
> "The usage of grep in RUN lines is deprecated - please do not send or
> commit patches that use it."
>
> >
> >
> > On Fri, Jun 21, 2013 at 9:39 AM, Jordan Rose <jordan_rose at apple.com>
> wrote:
> >>
> >> Please use FileCheck instead of grep.
> >>
> >>
> >> On Jun 21, 2013, at 8:56 , Larisse Voufo <lvoufo at google.com> wrote:
> >>
> >> > Author: lvoufo
> >> > Date: Fri Jun 21 10:56:15 2013
> >> > New Revision: 184559
> >> >
> >> > URL: http://llvm.org/viewvc/llvm-project?rev=184559&view=rev
> >> > Log:
> >> > Add basic fixit test to template instantiation bug fix (r184503)
> >> >
> >> > Modified:
> >> >    cfe/trunk/test/CXX/temp/temp.spec/no-body.cpp
> >> >
> >> > Modified: cfe/trunk/test/CXX/temp/temp.spec/no-body.cpp
> >> > URL:
> >> >
> http://llvm.org/viewvc/llvm-project/cfe/trunk/test/CXX/temp/temp.spec/no-body.cpp?rev=184559&r1=184558&r2=184559&view=diff
> >> >
> >> >
> ==============================================================================
> >> > --- cfe/trunk/test/CXX/temp/temp.spec/no-body.cpp (original)
> >> > +++ cfe/trunk/test/CXX/temp/temp.spec/no-body.cpp Fri Jun 21 10:56:15
> >> > 2013
> >> > @@ -1,4 +1,7 @@
> >> > // RUN: %clang_cc1 -fsyntax-only -verify %s
> >> > +// RUN: cp %s %t
> >> > +// RUN: not %clang_cc1 -fsyntax-only -fixit -x c++ %t
> >> > +// RUN: grep test_string %t
> >> >
> >> > template<typename T> void f(T) { }
> >> > template<typename T> void g(T) { }
> >> >
> >> >
> >> > _______________________________________________
> >> > cfe-commits mailing list
> >> > cfe-commits at cs.uiuc.edu
> >> > http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits
> >>
> >
> >
> > _______________________________________________
> > cfe-commits mailing list
> > cfe-commits at cs.uiuc.edu
> > http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits
> >
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20130621/56cb8b46/attachment.html>