[PATCH] Enhancements for the DynTypedMatcher system.

[Manuel Klimek]

  LG. Cool!


================
Comment at: include/clang/ASTMatchers/ASTMatchersInternal.h:188
@@ -187,1 +187,3 @@
 
+template <typename T> class Matcher;
+
----------------
Is this still needed?

================
Comment at: include/clang/ASTMatchers/ASTMatchersInternal.h:257
@@ -248,1 +256,3 @@
 
+  /// \brief Returns \c true if the pass DynTypedMatcher can be converted to \c
+  ///   Matcher<T>.
----------------
s/pass/passed/

================
Comment at: include/clang/ASTMatchers/ASTMatchersInternal.h:258
@@ +257,3 @@
+  /// \brief Returns \c true if the pass DynTypedMatcher can be converted to \c
+  ///   Matcher<T>.
+  ///
----------------
and I'd probably say to "a" Matcher<T>

================
Comment at: include/clang/ASTMatchers/ASTMatchersInternal.h:267
@@ +266,3 @@
+
+  /// \brief Construct a Matcher<T> interface around the dynamic \c Other.
+  ///
----------------
dynamic "matcher" \c Other.

================
Comment at: include/clang/ASTMatchers/ASTMatchersInternal.h:274
@@ +273,3 @@
+    assert(canConstructFrom(Other));
+    return Matcher<T>(new WrappedMatcher(Other));
+  }
----------------
I'm wondering whether there's a simpler way - but probably not, as we don't have access to the internals of the "real matcher" behind the DynTypedMatcher 'Other'.


http://llvm-reviews.chandlerc.com/D815

BRANCH
  dyn_type_check

ARCANIST PROJECT
  clang