[PATCH] Fix a crash in the static analyzer bug #16307
Jordan Rose
jordan_rose at apple.com
Wed Jun 19 09:14:52 PDT 2013
In the future, please wait until you get an explicit sign-off on a commit ("LGTM", "go ahead and commit", or a Phabricator acceptance) before committing. We'll all watch for post-commit review, of course, but when you're committing to a new area of Clang for the first time it's better to get an explicit go-ahead.
The final patch looks fine, though I could grumble a bit more about the message. ("fewer", not "less", for countable nouns, and having the number in trailing parens, rather than rephrasing somehow, looks funny to me.) But if those had really been important I would have commented before; they're just my personal opinions.
http://llvm-reviews.chandlerc.com/D994
COMMIT
http://llvm-reviews.chandlerc.com/rL184288
More information about the cfe-commits
mailing list