[PATCH] Completely revamp node binding for AST matchers.

[Manuel Klimek]

On Wed, Jun 19, 2013 at 5:38 PM, Edwin Vane <edwin.vane at intel.com> wrote:

>
>
> ================
> Comment at: lib/ASTMatchers/ASTMatchFinder.cpp:388
> @@ +387,3 @@
> +    if (ResultCache.size() > MaxMemoizationEntries)
> +      ResultCache.clear();
> +    std::pair<MemoizationMap::iterator, bool> InsertResult =
> ----------------
> Is it worth adding a FIXME to look into other cache ejection strategies?
> Would it make a difference for performance?
>

I already have a fixme with the definition of MaxMemoizationEntries... I
don't think it'll make much of a difference though. But we'll need some
more micro-benchmarks ...


>
>
> http://llvm-reviews.chandlerc.com/D992
>
> BRANCH
>   explode-review
>
> ARCANIST PROJECT
>   clang
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20130619/2c676ac0/attachment.html>