r183631 - [CodeGen] Move EHScopeStack to CGCleanup.h from CodeGenFunction.h

[John McCall]

On Jun 18, 2013, at 5:11 PM, David Blaikie <dblaikie at gmail.com> wrote:
> On Tue, Jun 18, 2013 at 5:07 PM, John McCall <rjmccall at apple.com> wrote:
>> On Jun 9, 2013, at 9:45 AM, Reid Kleckner <reid at kleckner.net> wrote:
>>> Author: rnk
>>> Date: Sun Jun  9 11:45:02 2013
>>> New Revision: 183631
>>> 
>>> URL: http://llvm.org/viewvc/llvm-project?rev=183631&view=rev
>>> Log:
>>> [CodeGen] Move EHScopeStack to CGCleanup.h from CodeGenFunction.h
>>> 
>>> No functionality change.  CGCleanup.cpp provides the implementation for
>>> EHScopeStack, so it seems more consistent to place the class definition
>>> in CGCleanup.h.
>> 
>> So, I specifically wasn't doing this because I didn't want to include
>> CGCleanup.h in every file in IR-gen, basically because I didn't want
>> random files depending on the cleanup-stack details.
> 
> So, should we just pull out EHScopeStack into it's own header &
> implementation file?

I don't know why specifically you care about giving it its own
implementation file, but putting it in its own header isn't unreasonable.

John.