[PATCH] Prevent LoopConvert from shadowing already defined variables with the same name as the loop variable.

Edwin Vane edwin.vane at intel.com
Tue Jun 18 11:05:36 PDT 2013



================
Comment at: cpp11-migrate/LoopConvert/VariableNaming.cpp:152
@@ +151,3 @@
+    Start = *Parent;
+  } while (1);
+
----------------
Ariel Bernal wrote:
> Manuel Klimek wrote:
> > This actually looks useful - we might want to get this into a more common library, together with a whole bunch of unit tests (perhaps add a FIXME to that end)
> Yes no problem, I'll add the FIXME and also I'm adding some positive and negative tests to naming-conflict.cpp in the next patch. What do you mean with a more common library?
I would assume putting this code into clang itself somewhere.


http://llvm-reviews.chandlerc.com/D950



More information about the cfe-commits mailing list