[PATCH] pr13012: Support -fpcc-struct-return for x86-32

Arthur O'Dwyer arthur.j.odwyer at gmail.com
Mon Jun 17 17:17:10 PDT 2013


On Mon, Jun 17, 2013 at 4:42 PM, John McCall <rjmccall at apple.com> wrote:
> On Jun 17, 2013, at 11:54 AM, Arthur O'Dwyer <arthur.j.odwyer at gmail.com> wrote:
>>
>> Is there anything preventing this patch
>> from going in, at this point?
>>
>> I've attached two versions of the patch: one with SRC_OnStack and
>> SRC_InRegs, and one with SRCK_OnStack and SRCK_InRegs. There's no
>> other difference between them. I believe I prefer the SRCK_ version;
>> thanks, Jordan!
>
> Either one LGTM.

Hooray! John, could you please commit the SRCK_ version?

(I believe I don't have checkin privileges, which is a special case of
"random strangers don't have checkin privileges", which is a good
thing. But FWIW, I can't figure out how one gets such privileges. I
would have expected it to be explained on
http://clang.llvm.org/hacking.html.)

Thanks,
-Arthur



More information about the cfe-commits mailing list