r184068 - Add warning group -Wdeprecated-register for C++11 warning on 'register' being

Arthur O'Dwyer arthur.j.odwyer at gmail.com
Mon Jun 17 14:10:50 PDT 2013


On Mon, Jun 17, 2013 at 2:04 PM, Richard Smith <richard at metafoo.co.uk> wrote:
>
> GCC uses -Wdeprecated-declarations for __attribute__((deprecated)),
> and uses -Wdeprecated for deprecated language features (or at least
> for access declarations). It does not treat -Wdeprecated-declarations
> as a subgroup of -Wdeprecated.
>
> How about: we move the three separate -Wdeprecated-* warnings into
> -Wdeprecated, move the two ??? warnings into -Wdeprecated, rename
> -Wdeprecated-declarations to -Wdeprecated-attribute (with a
> compatibility synonym to -Wdeprecated-declarations), and remove it
> from the -Wdeprecated group.

Beware that -Wdeprecated-implementations is closely akin to
-Wdeprecated-declarations (it's sort of the Objective-C version of
that warning, emitted when you try to implement a deprecated @protocol
method), so you should be careful to keep those two options parallel
in construction. IMO you shouldn't add any special treatment to
-Wdeprecated-declarations that you don't also add to
-Wdeprecated-implementations.

Other than that, this sounds like an excellent plan. Moving the (???)
warnings into -Wdeprecated is certainly overdue, and removing
-Wdeprecated-declarations from -Wdeprecated sounds like a good idea.

my $.02,
-Arthur



More information about the cfe-commits mailing list