[PATCH] cpp11-migrate: Replace file override container

Tareq A. Siraj tareq.a.siraj at intel.com
Thu Jun 13 08:49:49 PDT 2013


  Minor comments, otherwise LGTM.


================
Comment at: cpp11-migrate/Core/FileOverrides.h:30
@@ +29,3 @@
+struct SourceOverrides {
+  //SourceOverrides() {}
+
----------------
Remove commented out code if not needed.

================
Comment at: cpp11-migrate/Core/SyntaxCheck.cpp:39
@@ +38,3 @@
+
+class EndSyntaxArgumentsAdjuster : public ArgumentsAdjuster {
+  CommandLineArguments Adjust(const CommandLineArguments &Args) {
----------------
Maybe call it FinalSyntaxArgumentAdjuster to be consistent with the Action name?


http://llvm-reviews.chandlerc.com/D964

BRANCH
  override_structs

ARCANIST PROJECT
  clang-tools-extra



More information about the cfe-commits mailing list