r183697 - cleanup (address some more review comments for r183474):

Adrian Prantl aprantl at apple.com
Mon Jun 10 14:36:55 PDT 2013


Author: adrian
Date: Mon Jun 10 16:36:55 2013
New Revision: 183697

URL: http://llvm.org/viewvc/llvm-project?rev=183697&view=rev
Log:
cleanup (address some more review comments for r183474):
- reduce default buffer size to 64, which will still be large enough to
  hold any property names found in the wild.
- get rid of the /*static*/ comments.

Modified:
    cfe/trunk/include/clang/Basic/IdentifierTable.h
    cfe/trunk/lib/Basic/IdentifierTable.cpp

Modified: cfe/trunk/include/clang/Basic/IdentifierTable.h
URL: http://llvm.org/viewvc/llvm-project/cfe/trunk/include/clang/Basic/IdentifierTable.h?rev=183697&r1=183696&r2=183697&view=diff
==============================================================================
--- cfe/trunk/include/clang/Basic/IdentifierTable.h (original)
+++ cfe/trunk/include/clang/Basic/IdentifierTable.h Mon Jun 10 16:36:55 2013
@@ -730,7 +730,7 @@ public:
   ///
   /// This is "set" + \p Name where the initial character of \p Name
   /// has been capitalized.
-  static SmallString<100> constructSetterName(StringRef Name);
+  static SmallString<64> constructSetterName(StringRef Name);
 
   /// \brief Return the default setter selector for the given identifier.
   ///

Modified: cfe/trunk/lib/Basic/IdentifierTable.cpp
URL: http://llvm.org/viewvc/llvm-project/cfe/trunk/lib/Basic/IdentifierTable.cpp?rev=183697&r1=183696&r2=183697&view=diff
==============================================================================
--- cfe/trunk/lib/Basic/IdentifierTable.cpp (original)
+++ cfe/trunk/lib/Basic/IdentifierTable.cpp Mon Jun 10 16:36:55 2013
@@ -463,15 +463,15 @@ static SelectorTableImpl &getSelectorTab
   return *static_cast<SelectorTableImpl*>(P);
 }
 
-/*static*/ SmallString<100>
+SmallString<64>
 SelectorTable::constructSetterName(StringRef Name) {
-  SmallString<100> SelectorName("set");
-  SelectorName += Name;
-  SelectorName[3] = toUppercase(SelectorName[3]);
-  return SelectorName;
+  SmallString<64> SetterName("set");
+  SetterName += Name;
+  SetterName[3] = toUppercase(SetterName[3]);
+  return SetterName;
 }
 
-/*static*/ Selector
+Selector
 SelectorTable::constructSetterSelector(IdentifierTable &Idents,
                                        SelectorTable &SelTable,
                                        const IdentifierInfo *Name) {





More information about the cfe-commits mailing list