[PATCH] Private Headers for Modules

Dmitri Gribenko gribozavr at gmail.com
Fri Jun 7 20:31:17 PDT 2013



================
Comment at: include/clang/Lex/HeaderSearch.h:61
@@ -59,1 +60,3 @@
+  /// \brief Whether this header is part of the module that we are building.
+  ModuleMap::ModuleHeaderRole HeaderRole : 2;
   
----------------
IIRC, this should be unsigned because MSVC does not like bitfields with signed enum types.


================
Comment at: include/clang/Lex/ModuleMap.h:205-207
@@ -187,5 +204,5 @@
   ///
   /// \returns The module that owns the given header file, or null to indicate
   /// that no module owns this header file.
-  Module *findModuleForHeader(const FileEntry *File);
+  KnownHeader findModuleForHeader(const FileEntry *File);
 
----------------
The name and \returns documentation now don't quite reflect the actual return value.


http://llvm-reviews.chandlerc.com/D834



More information about the cfe-commits mailing list