r183582 - address some comments on r183474:

[Eric Christopher]

Hi Adrian,

Few more comments:

> +  static SmallString<100> constructSetterName(StringRef Name);
> +

Probably just want to return the string here, Small* are more useful
when they're stack variables and now you're passing much larger things
around (given you've set a size of 100 - which I'm reasonably positive
was just a WAG).

> +/*static*/ SmallString<100>

No commented out static please.

> +SelectorTable::constructSetterName(StringRef Name) {
> +  SmallString<100> SelectorName("set");
> +  SelectorName += Name;
>    SelectorName[3] = toUppercase(SelectorName[3]);
> -  IdentifierInfo *SetterName = &Idents.get(SelectorName);
> +  return SelectorName;
>

Why are we capitalizing SelectorName[3] again?

-eric