r183312 - UTF-8 support for clang-format.

Alexander Kornienko alexfh at google.com
Fri Jun 7 14:53:08 PDT 2013


As I've mentioned earlier in this thread, I'm going to make this and some
of the other clang-format tests file-based. So there won't be need to
escape anything and to deal with various compilers treating encodings
differently.
On Jun 7, 2013 11:41 PM, "Sean Silva" <silvas at purdue.edu> wrote:

>
>
>
> On Fri, Jun 7, 2013 at 9:49 AM, Alexander Kornienko <alexfh at google.com>wrote:
>
>> Readability. I think, we already have enough complexity in clang-format
>> tests. I'd not make things even worse here.
>>
>>
>>
>> On Fri, Jun 7, 2013 at 6:39 PM, Jordan Rose <jordan_rose at apple.com>wrote:
>>
>>> What's wrong with using escapes? (Other than readability....or is that
>>> it?)
>>>
>>>
> IMO using escapes is not as bad as having to special-case the file
> encoding of this file. Also I don't think that the Standard necessarily
> guarantees that those string literals will be represented as UTF-8 in the
> resulting program. You can add the "actual text" in a comment to preserve
> readability.
>
> -- Sean Silva
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20130607/20204fb0/attachment.html>


More information about the cfe-commits mailing list