r183312 - UTF-8 support for clang-format.

Alexander Kornienko alexfh at google.com
Fri Jun 7 09:49:01 PDT 2013


Readability. I think, we already have enough complexity in clang-format
tests. I'd not make things even worse here.


On Fri, Jun 7, 2013 at 6:39 PM, Jordan Rose <jordan_rose at apple.com> wrote:

> What's wrong with using escapes? (Other than readability....or is that it?)
>
> On Jun 7, 2013, at 8:46 , Alexander Kornienko <alexfh at google.com> wrote:
>
> A bit more information: the issue that tracks support for UTF-8 BOM is
> http://gcc.gnu.org/bugzilla/show_bug.cgi?id=33415. The patch seems to be
> present in GCC from version 4.4.0 on. LLVM claims to support GCC from 3.4
> (with numerous exceptions):
> http://llvm.org/docs/GettingStarted.html#software
>
> So I'd better not introduce a change that would even more disappoint poor
> guys who still have to deal with older GCC versions.
>
> I'll leave it #ifdefed out until we move it to a file-based test.
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20130607/89182fc8/attachment.html>


More information about the cfe-commits mailing list