[Patch] Disallow reinterpret_cast from pointer to bool on Windows (PR16222)

[Hans Wennborg]

Thanks! r183394.

 - Hans

On Wed, Jun 5, 2013 at 4:06 PM, Aaron Ballman <aaron at aaronballman.com> wrote:
> Patch LGTM
>
> ~Aaron
>
> On Wed, Jun 5, 2013 at 9:31 AM, Hans Wennborg <hans at chromium.org> wrote:
>> Hi all,
>>
>> This patch makes Clang disallow reinterpret_cast from pointer to bool
>> on Windows.
>>
>> Currently, it's allowed by accident and later triggers an exception.
>> Support was added in r131201 to allow conversion from pointers to
>> integral types on windows since this is apparently used in system
>> headers. However, converting pointers to bool is already supported in
>> a civilized manner via static_cast and c-style cast. Allowing it
>> through reinterpret_cast seems like a bad idea.
>>
>> Please take a look.
>>
>> Thanks,
>> Hans
>>
>> _______________________________________________
>> cfe-commits mailing list
>> cfe-commits at cs.uiuc.edu
>> http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits
>>