[clang-tools-extra] r183154 - cpp11-migrate: turn off PID-based perf data filenames

Kim Gräsman kim.grasman at gmail.com
Thu Jun 6 00:48:59 PDT 2013


On Wed, Jun 5, 2013 at 3:10 PM, Vane, Edwin <edwin.vane at intel.com> wrote:
> Go for it. CC me on the Phab review though so I know when the change is made.

It's in the mail.

One thing that struck me with the original problem was that the code
above assumed the PID was an "unsigned". It might have worked as-is if
it had done:

  llvm::sys::process::id_type Pid = SP->get_id();

depending on if raw_string_ostream has an overload for operator<<(..., void*).

You'd still get unique results, but it would no longer be the PID. Not
sure if that was relevant.

- Kim



More information about the cfe-commits mailing list