[PATCH] clang-check: Enable specification of additional compiler arguments
Pavel Labath
labath at google.com
Wed Jun 5 09:21:59 PDT 2013
- Fixup D919
Hi klimek,
http://llvm-reviews.chandlerc.com/D919
CHANGE SINCE LAST DIFF
http://llvm-reviews.chandlerc.com/D919?vs=2271&id=2275#toc
Files:
test/Tooling/clang-check-extra-arg.cpp
tools/clang-check/ClangCheck.cpp
Index: test/Tooling/clang-check-extra-arg.cpp
===================================================================
--- /dev/null
+++ test/Tooling/clang-check-extra-arg.cpp
@@ -0,0 +1,5 @@
+// RUN: clang-check "%s" -extra-arg=-Wunimplemented-warning -extra-arg-before=-Wunimplemented-warning-before -- -c 2>&1 | FileCheck %s
+
+// CHECK: unknown warning option '-Wunimplemented-warning-before'
+// CHECK: unknown warning option '-Wunimplemented-warning'
+int a(){}
Index: tools/clang-check/ClangCheck.cpp
===================================================================
--- tools/clang-check/ClangCheck.cpp
+++ tools/clang-check/ClangCheck.cpp
@@ -70,6 +70,11 @@
"fix-what-you-can",
cl::desc(Options->getOptionHelpText(options::OPT_fix_what_you_can)));
+static cl::list<std::string> ArgsAfter("extra-arg",
+ cl::desc("Additional argument to append to the compiler command line"));
+static cl::list<std::string> ArgsBefore("extra-arg-before",
+ cl::desc("Additional argument to prepend to the compiler command line"));
+
namespace {
// FIXME: Move FixItRewriteInPlace from lib/Rewrite/Frontend/FrontendActions.cpp
@@ -123,6 +128,35 @@
}
};
+class InsertAdjuster: public clang::tooling::ArgumentsAdjuster {
+public:
+ enum Position { BEGIN, END };
+
+ InsertAdjuster(const CommandLineArguments &Extra, Position Pos)
+ : Extra(Extra), Pos(Pos) {
+ }
+
+ virtual CommandLineArguments
+ Adjust(const CommandLineArguments &Args) LLVM_OVERRIDE {
+ CommandLineArguments Return(Args);
+
+ CommandLineArguments::iterator I;
+ if (Pos == END) {
+ I = Return.end();
+ } else {
+ I = Return.begin();
+ ++I; // To leave the program name in place
+ }
+
+ Return.insert(I, Extra.begin(), Extra.end());
+ return Return;
+ }
+
+private:
+ const CommandLineArguments Extra;
+ const Position Pos;
+};
+
} // namespace
// Anonymous namespace here causes problems with gcc <= 4.4 on MacOS 10.6.
@@ -147,6 +181,12 @@
CommonOptionsParser OptionsParser(argc, argv);
ClangTool Tool(OptionsParser.getCompilations(),
OptionsParser.getSourcePathList());
+
+ if (ArgsAfter.size() > 0)
+ Tool.appendArgumentsAdjuster(new InsertAdjuster(ArgsAfter, InsertAdjuster::END));
+ if (ArgsBefore.size() > 0)
+ Tool.appendArgumentsAdjuster(new InsertAdjuster(ArgsBefore, InsertAdjuster::BEGIN));
+
if (Fixit)
return Tool.run(newFrontendActionFactory<FixItAction>());
clang_check::ClangCheckActionFactory Factory;
-------------- next part --------------
A non-text attachment was scrubbed...
Name: D919.3.patch
Type: text/x-patch
Size: 2495 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20130605/4f5df219/attachment.bin>
More information about the cfe-commits
mailing list