[PATCH] Initial clang-tidy architecture

Manuel Klimek klimek at google.com
Wed Jun 5 07:33:04 PDT 2013


  Cool, this looks like a step in the right direction.


================
Comment at: clang-tidy/ClangTidy.h:29
@@ +28,3 @@
+///
+/// This is used as an intermediate format to transport Diagnostics without a
+/// dependency on a SourceManager. The goal is to make Diagnostics flexible
----------------
FIXME

================
Comment at: clang-tidy/ClangTidy.h:55
@@ +54,3 @@
+  /// This is still under heavy development and will likely change towards using
+  /// tablegen'd diagnostic IDs.
+  DiagnosticBuilder Diag(SourceLocation Loc, StringRef Message) {
----------------
Not sure how we'd want to manage ID spaces...


http://llvm-reviews.chandlerc.com/D884



More information about the cfe-commits mailing list