r183251 - [ms-cxxabi] Factor out some loops into helpers for readability

[Reid Kleckner]

Author: rnk
Date: Tue Jun  4 16:32:29 2013
New Revision: 183251

URL: http://llvm.org/viewvc/llvm-project?rev=183251&view=rev
Log:
[ms-cxxabi] Factor out some loops into helpers for readability

No functionality change, covered by the existing virtual base adjustment
tests.

Modified:
    cfe/trunk/lib/CodeGen/MicrosoftCXXABI.cpp

Modified: cfe/trunk/lib/CodeGen/MicrosoftCXXABI.cpp
URL: http://llvm.org/viewvc/llvm-project/cfe/trunk/lib/CodeGen/MicrosoftCXXABI.cpp?rev=183251&r1=183250&r2=183251&view=diff
==============================================================================
--- cfe/trunk/lib/CodeGen/MicrosoftCXXABI.cpp (original)
+++ cfe/trunk/lib/CodeGen/MicrosoftCXXABI.cpp Tue Jun  4 16:32:29 2013
@@ -233,6 +233,18 @@ llvm::Value *MicrosoftCXXABI::adjustToCo
   return ptr;
 }
 
+/// \brief Finds the first non-virtual base of RD that has virtual bases.  If RD
+/// doesn't have a vbptr, it will reuse the vbptr of the returned class.
+static const CXXRecordDecl *FindFirstNVBaseWithVBases(const CXXRecordDecl *RD) {
+  for (CXXRecordDecl::base_class_const_iterator I = RD->bases_begin(),
+       E = RD->bases_end(); I != E; ++I) {
+    const CXXRecordDecl *Base = I->getType()->getAsCXXRecordDecl();
+    if (!I->isVirtual() && Base->getNumVBases() > 0)
+      return Base;
+  }
+  llvm_unreachable("RD must have an nv base with vbases");
+}
+
 CharUnits MicrosoftCXXABI::GetVBPtrOffsetFromBases(const CXXRecordDecl *RD) {
   assert(RD->getNumVBases());
   CharUnits Total = CharUnits::Zero();
@@ -244,24 +256,30 @@ CharUnits MicrosoftCXXABI::GetVBPtrOffse
       Total += VBPtrOffset;
       break;
     }
-
-    // RD is reusing the vbptr of a non-virtual base.  Find it and continue.
-    const CXXRecordDecl *FirstNVBaseWithVBases = 0;
-    for (CXXRecordDecl::base_class_const_iterator I = RD->bases_begin(),
-         E = RD->bases_end(); I != E; ++I) {
-      const CXXRecordDecl *Base = I->getType()->getAsCXXRecordDecl();
-      if (!I->isVirtual() && Base->getNumVBases() > 0) {
-        FirstNVBaseWithVBases = Base;
-        break;
-      }
-    }
-    assert(FirstNVBaseWithVBases);
-    Total += RDLayout.getBaseClassOffset(FirstNVBaseWithVBases);
-    RD = FirstNVBaseWithVBases;
+    RD = FindFirstNVBaseWithVBases(RD);
+    Total += RDLayout.getBaseClassOffset(RD);
   }
   return Total;
 }
 
+/// \brief Computes the index of BaseClassDecl in the vbtable of ClassDecl.
+/// BaseClassDecl must be a morally virtual base of ClassDecl.  The vbtable is
+/// an array of i32 offsets.  The first entry is a self entry, and the rest are
+/// offsets from the vbptr to virtual bases.  The bases are ordered the same way
+/// our vbases are ordered: as they appear in a left-to-right depth-first search
+/// of the hierarchy.
+static unsigned GetVBTableIndex(const CXXRecordDecl *ClassDecl,
+                                const CXXRecordDecl *BaseClassDecl) {
+  unsigned VBTableIndex = 1;  // Start with one to skip the self entry.
+  for (CXXRecordDecl::base_class_const_iterator I = ClassDecl->vbases_begin(),
+       E = ClassDecl->vbases_end(); I != E; ++I) {
+    if (I->getType()->getAsCXXRecordDecl() == BaseClassDecl)
+      return VBTableIndex;
+    VBTableIndex++;
+  }
+  llvm_unreachable("BaseClassDecl must be a vbase of ClassDecl");
+}
+
 llvm::Value *
 MicrosoftCXXABI::GetVirtualBaseClassOffset(CodeGenFunction &CGF,
                                            llvm::Value *This,
@@ -269,22 +287,8 @@ MicrosoftCXXABI::GetVirtualBaseClassOffs
                                            const CXXRecordDecl *BaseClassDecl) {
   int64_t VBPtrChars = GetVBPtrOffsetFromBases(ClassDecl).getQuantity();
   llvm::Value *VBPtrOffset = llvm::ConstantInt::get(CGM.PtrDiffTy, VBPtrChars);
-
-  // The vbtable is an array of i32 offsets.  The first entry is a self entry,
-  // and the rest are offsets from the vbptr to virtual bases.  The bases are
-  // ordered the same way our vbases are ordered: as they appear in a
-  // left-to-right depth-first search of the hierarchy.
-  unsigned VBTableIndex = 1;  // Start with one to skip the self entry.
-  for (CXXRecordDecl::base_class_const_iterator I = ClassDecl->vbases_begin(),
-       E = ClassDecl->vbases_end(); I != E; ++I) {
-    if (I->getType()->getAsCXXRecordDecl() == BaseClassDecl)
-      break;
-    VBTableIndex++;
-  }
-  assert(VBTableIndex != 1 + ClassDecl->getNumVBases() &&
-         "BaseClassDecl must be a vbase of ClassDecl");
   CharUnits IntSize = getContext().getTypeSizeInChars(getContext().IntTy);
-  CharUnits VBTableChars = IntSize * VBTableIndex;
+  CharUnits VBTableChars = IntSize * GetVBTableIndex(ClassDecl, BaseClassDecl);
   llvm::Value *VBTableOffset =
     llvm::ConstantInt::get(CGM.IntTy, VBTableChars.getQuantity());