[PATCH] cpp11-migrate: collect performance timers per source file

Ariel Bernal ariel.j.bernal at intel.com
Tue Jun 4 08:15:23 PDT 2013


  You may want to comment the get_id call for now. The rest looks good.


================
Comment at: cpp11-migrate/Core/PerfSupport.cpp:41
@@ +40,3 @@
+  llvm::sys::self_process *SP = llvm::sys::process::get_self();
+  unsigned Pid = SP->get_id();
+  llvm::TimeRecord T = llvm::TimeRecord::getCurrentTime();
----------------
I'm looking into a fix for this, but I don't have any machine to test.

================
Comment at: cpp11-migrate/Core/PerfSupport.cpp:57
@@ +56,3 @@
+    // Terminate the last source with a comma before continuing to the next one.
+    if (I != TimingResults.begin())
+      FileStream << ",\n";
----------------
This is a much better approach (no hanging comma).


http://llvm-reviews.chandlerc.com/D912



More information about the cfe-commits mailing list