[PATCH] Add support for .bind("foo") expressions on the dynamic matchers.

Samuel Benzaquen sbenza at google.com
Mon Jun 3 11:58:00 PDT 2013



================
Comment at: include/clang/ASTMatchers/ASTMatchersInternal.h:248
@@ +247,3 @@
+
+  /// \brief Bind the specified \c ID to the matcher.
+  /// \return A new matcher with the \c ID bound to it if this matcher supports
----------------
Manuel Klimek wrote:
> Here and below - always use \p for referencing parameters.
Done.

================
Comment at: lib/ASTMatchers/Dynamic/Registry.cpp:157
@@ +156,3 @@
+                                                 Diagnostics *Error) {
+  DynTypedMatcher *Out = constructMatcher(MatcherName, NameRange, Args, Error);
+  if (!Out) return NULL;
----------------
Manuel Klimek wrote:
> use an OwningPtr?
Done.


http://llvm-reviews.chandlerc.com/D911

BRANCH
  bind

ARCANIST PROJECT
  clang



More information about the cfe-commits mailing list