[PATCH] Add support for .bind("foo") expressions on the dynamic matchers.
Manuel Klimek
klimek at google.com
Mon Jun 3 11:12:40 PDT 2013
LG with some nits
================
Comment at: include/clang/ASTMatchers/ASTMatchersInternal.h:248
@@ +247,3 @@
+
+ /// \brief Bind the specified \c ID to the matcher.
+ /// \return A new matcher with the \c ID bound to it if this matcher supports
----------------
Here and below - always use \p for referencing parameters.
================
Comment at: lib/ASTMatchers/Dynamic/Registry.cpp:157
@@ +156,3 @@
+ Diagnostics *Error) {
+ DynTypedMatcher *Out = constructMatcher(MatcherName, NameRange, Args, Error);
+ if (!Out) return NULL;
----------------
use an OwningPtr?
http://llvm-reviews.chandlerc.com/D911
BRANCH
bind
ARCANIST PROJECT
clang
More information about the cfe-commits
mailing list