[PATCH] Initial clang-tidy architecture
Sean Silva
silvas at purdue.edu
Wed May 29 12:07:45 PDT 2013
================
Comment at: clang-tidy/llvm/LLVMModule.cpp:88
@@ +87,3 @@
+ StringRef SourceFile = Sources.getFilename(HashLoc);
+ if (!SourceFile.endswith(".cc"))
+ return;
----------------
Daniel Jasper wrote:
> Sean Silva wrote:
> > Shouldn't this be checking LangOptions instead of the extension? e.g. this wouldn't work for LLVM's `.cpp` naming.
> This is a dummy implementation. Any real order-check will be totally different.
Please indicate this clearly somewhere!
http://llvm-reviews.chandlerc.com/D884
More information about the cfe-commits
mailing list