r182866 - [ms-cxxabi] Fix r182865 to have an actual Itanium-style key function

Reid Kleckner reid at kleckner.net
Wed May 29 09:51:18 PDT 2013


Author: rnk
Date: Wed May 29 11:51:17 2013
New Revision: 182866

URL: http://llvm.org/viewvc/llvm-project?rev=182866&view=rev
Log:
[ms-cxxabi] Fix r182865 to have an actual Itanium-style key function

Peter pointed out that C::f() is not a key function.  C's key function
is actually C::~C().

Modified:
    cfe/trunk/test/CodeGenCXX/microsoft-abi-vtables-single-inheritance.cpp

Modified: cfe/trunk/test/CodeGenCXX/microsoft-abi-vtables-single-inheritance.cpp
URL: http://llvm.org/viewvc/llvm-project/cfe/trunk/test/CodeGenCXX/microsoft-abi-vtables-single-inheritance.cpp?rev=182866&r1=182865&r2=182866&view=diff
==============================================================================
--- cfe/trunk/test/CodeGenCXX/microsoft-abi-vtables-single-inheritance.cpp (original)
+++ cfe/trunk/test/CodeGenCXX/microsoft-abi-vtables-single-inheritance.cpp Wed May 29 11:51:17 2013
@@ -48,7 +48,6 @@ struct C {
   virtual void f();
 };
 void C::f() {}
-// The usual Itanium-style key method does not cause vtable emission.
 // NO-VTABLE-NOT: @"\01??_7C@@6B@"
 
 struct D {
@@ -115,3 +114,10 @@ struct G : E {
 };
 void G::j() {}
 // NO-VTABLE-NOT: @"\01??_7G@@6B@"
+
+// Test that the usual Itanium-style key method does not emit a vtable.
+struct H {
+  virtual void f();
+};
+void H::f() {}
+// NO-VTABLE-NOT: @"\01??_7H@@6B@"





More information about the cfe-commits mailing list