[PATCH] [ms-cxxabi] There are no key functions in the Microsoft C++ ABI

[Peter Collingbourne]

  LGTM with a few nits.


================
Comment at: test/CodeGenCXX/microsoft-abi-vtables-single-inheritance.cpp:119
@@ -112,2 +118,2 @@
 };
 void G::j() {}
----------------
Please also add a test which shows that defining what would be the key function in the Itanium ABI does not cause a vtable to be emitted.

================
Comment at: test/CodeGenCXX/microsoft-abi-vtables-single-inheritance.cpp:20
@@ +19,3 @@
+// EMITS-VTABLE: @"\01??_7B@@6B@" = linkonce_odr unnamed_addr constant [5 x i8*]
+// EMITS-VTABLE: @"\01??_7A@@6B@" = linkonce_odr unnamed_addr constant [3 x i8*]
+
----------------
Please use the new EMITS-VTABLE-DAG directive (aka CHECK-DAG) for these, so they can be placed with their definitions.  (I think the EMITS-VTABLE-NOTs will have to be part of a separate FileCheck invocation.)


http://llvm-reviews.chandlerc.com/D838

BRANCH
  key-method

ARCANIST PROJECT
  clang