r180976 - Move parsing of identifiers in MS-style inline assembly into

Hans Wennborg hans at chromium.org
Tue May 28 09:43:07 PDT 2013


Thanks!

On Fri, May 24, 2013 at 7:38 PM, Chad Rosier <mcrosier at apple.com> wrote:
> Reid,
> I believe r182659 addresses the issue.
>
> John probably has a better long-term solution, but this should get you guys
> back to a working state.
>
>  Chad
>
> On May 21, 2013, at 11:33 AM, Reid Kleckner <rnk at google.com> wrote:
>
> Chad, is anyone actively working on this, or is this available to work on?
> This breaks a bunch of stuff for us.
>
>
> On Tue, May 14, 2013 at 6:03 PM, John McCall <rjmccall at apple.com> wrote:
>>
>> On May 14, 2013, at 8:25 AM, Hans Wennborg <hans at chromium.org> wrote:
>> > On Fri, May 3, 2013 at 1:10 AM, John McCall <rjmccall at apple.com> wrote:
>> >> Author: rjmccall
>> >> Date: Thu May  2 19:10:13 2013
>> >> New Revision: 180976
>> >>
>> >> URL: http://llvm.org/viewvc/llvm-project?rev=180976&view=rev
>> >> Log:
>> >> Move parsing of identifiers in MS-style inline assembly into
>> >> the actual parser and support arbitrary id-expressions.
>> >
>> > This seems to have broken the ability to use labels inside MS-style
>> > inline assembly. For example, the following no longer compiles:
>> >
>> >  void foo() {
>> >    __asm {
>> >  a:
>> >      jmp a
>> >    }
>> >  }
>> >
>> > because Clang now errors out when it fails to look up the identifier
>> > "a".
>> >
>> > Do you have any ideas for a good way to handle this?
>>
>> The interface should probably have a way to say that the frontend just
>> didn't recognize a name, and Clang should trigger that when it sees a
>> bare identifier that's not in the lookup tables.
>>
>> John.
>> _______________________________________________
>> cfe-commits mailing list
>> cfe-commits at cs.uiuc.edu
>> http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits
>
>
>



More information about the cfe-commits mailing list