[patch] Warn on va_start() when called with a reference parameter

[Jordan Rose]

Your test case is named .cc (rather than .cpp) and as such is not getting run...which is important because it's actually broken.

All of va_start is implementation-defined behavior anyway, yes? I guess it's still a good warning, though.

Jordan


On May 23, 2013, at 22:07 , Nico Weber <thakis at chromium.org> wrote:

> Hi,
> 
> it's undefined behavior to call va_start() with a reference parameter. It happens to work fine with clang, but blows up with other compilers (e.g. msvs), so this patch adds a warning for it. It also moves 2 other existing warnings behind the new -Wvarargs flag.
> 
> Ok?
> 
> Nico
-------------- next part --------------
A non-text attachment was scrubbed...
Name: clang-vastart-ref.patch
Type: application/octet-stream
Size: 4697 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20130524/bca013ff/attachment.obj>
-------------- next part --------------
> _______________________________________________
> cfe-commits mailing list
> cfe-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits