[PATCH] Improve #pragma comment(lib) support

Aaron Ballman aaron at aaronballman.com
Thu May 23 14:05:16 PDT 2013


On Thu, May 23, 2013 at 5:02 PM, Rui Ueyama <ruiu at google.com> wrote:
> -    Consumer.HandleDependentLibrary(Arg);
> +    // If the argument does not end in .lib, automatically add the suffix.
> This
> +    // matches the behavior of MSVC.
> +    std::string ArgStr = Arg;
> +    StringRef End = Arg.substr( Arg.size() - 4 );
>
> Looks like it's not safe if Arg.size() < 4.

Hmm, that's a good point due to the unsigned subtraction.  Easy enough
to resolve.

~Aaron



More information about the cfe-commits mailing list