r182569 - Fix no-assert compiles.

David Blaikie dblaikie at gmail.com
Thu May 23 08:57:26 PDT 2013


On May 23, 2013 3:05 AM, "Manuel Klimek" <klimek at google.com> wrote:
>
> Author: klimek
> Date: Thu May 23 05:02:51 2013
> New Revision: 182569
>
> URL: http://llvm.org/viewvc/llvm-project?rev=182569&view=rev
> Log:
> Fix no-assert compiles.
>
> Modified:
>     cfe/trunk/lib/Format/UnwrappedLineParser.h
>
> Modified: cfe/trunk/lib/Format/UnwrappedLineParser.h
> URL:
http://llvm.org/viewvc/llvm-project/cfe/trunk/lib/Format/UnwrappedLineParser.h?rev=182569&r1=182568&r2=182569&view=diff
>
==============================================================================
> --- cfe/trunk/lib/Format/UnwrappedLineParser.h (original)
> +++ cfe/trunk/lib/Format/UnwrappedLineParser.h Thu May 23 05:02:51 2013
> @@ -127,7 +127,10 @@ public:
>    // the UnwrappedLineParser once we switch to generate all tokens
>    // up-front.
>    virtual unsigned getPosition() { return 0; }
> -  virtual FormatToken setPosition(unsigned Position) { assert(false); }
> +  virtual FormatToken setPosition(unsigned Position) {
> +    assert(false);
> +    return FormatToken();

Generally we use llvm_unreachable rather than assert(false)

> +  }
>  };
>
>  class UnwrappedLineParser {
>
>
> _______________________________________________
> cfe-commits mailing list
> cfe-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20130523/8d8331e2/attachment.html>


More information about the cfe-commits mailing list