[PATCH] Fix UseAuto replacing declaration lists with new expressions
Edwin Vane
edwin.vane at intel.com
Thu May 23 08:32:56 PDT 2013
================
Comment at: cpp11-migrate/UseAuto/UseAutoActions.cpp:128
@@ +127,3 @@
+ return;
+ const MemberPointerTypeLoc Q = cast<MemberPointerTypeLoc>(
+ V->getTypeSourceInfo()->getTypeLoc());
----------------
I'm not sure how this even works. Should be using PointerTypeLoc not MemberPointerTypeLoc.
================
Comment at: cpp11-migrate/UseAuto/UseAutoActions.cpp:80
@@ -79,1 +79,3 @@
+void removeStarsFromVarDecl(tooling::Replacements &Replace, SourceManager &SM,
+ SourceLocation FirstStarLoc) {
----------------
Instead of parsing, can we use Type and TypeLoc APIs to drill down through the pointers-to and call getStarLoc() on each PointerTypeLoc in the chain?
http://llvm-reviews.chandlerc.com/D839
More information about the cfe-commits
mailing list