[PATCH] Expand parsing of braced init lists.
Manuel Klimek
klimek at google.com
Thu May 23 02:44:27 PDT 2013
Submitted as r182568
================
Comment at: lib/Format/UnwrappedLineParser.h:221
@@ -205,1 +220,3 @@
+ // FIXME: This is a temporary measure until le have reworked the ownership
+ // of the format tokens. The goal is to have the actual tokens created and
----------------
Daniel Jasper wrote:
> s/le/we/
Done.
================
Comment at: lib/Format/UnwrappedLineParser.h:223
@@ +222,3 @@
+ // of the format tokens. The goal is to have the actual tokens created and
+ // owned outside of the UnwrappedLineParser, and handed into the
+ // UnwrappedLineParser.
----------------
Daniel Jasper wrote:
> how about just:
>
> // owned outside of and handed into the UnwrappedLineParser.
Done.
================
Comment at: lib/Format/UnwrappedLineParser.cpp:548
@@ +547,3 @@
+bool UnwrappedLineParser::tryToParseBracedList() {
+ if (LBraces[Tokens->getPosition()] == BS_Unknown) {
+ calculateBraceTypes();
----------------
Daniel Jasper wrote:
> No {}
Done.
================
Comment at: lib/Format/UnwrappedLineParser.cpp:136
@@ -126,1 +135,3 @@
+class AllTokenSource : public FormatTokenSource {
+public:
----------------
Daniel Jasper wrote:
> I know that this might be going away, but for now, how about "IndexedTokenSource"?
Done.
http://llvm-reviews.chandlerc.com/D848
More information about the cfe-commits
mailing list