[PATCH] Initial support for __sptr and __uptr

[Aaron Ballman]

On Wed, May 22, 2013 at 3:59 PM, Richard Smith <richard at metafoo.co.uk> wrote:
> +  // Pointer type qualifiers can only operate on pointer types, but not
> +  // pointer-to-member types.
> +  if (!Type->isPointerType() || Type->isMemberPointerType()) {
>
> You don't need the isMemberPointerType here.

Removed.

> This will still accept cases like:
>
> typedef int *P;
> P __ptr32 myp;
>
> I would suggest checking isa<PointerType> on the type you get after
> stripping off AttributedTypes.

I had an explicit test case in to ensure that worked because I felt it
was a reasonable use case.  Are you saying we should not allow it?

~Aaron