r182502 - [analyzer; alternate edges] remove puny edges on the same line that span less than 3 columns.

Jordan Rose jordan_rose at apple.com
Wed May 22 11:59:03 PDT 2013


Yeah, this is pretty much what I was thinking as well; the missing piece in my mind was that it has to run after regular optimization has hit its steady-state. But why is this pass working on statement-locations, instead of just flattening to a FullSourceLoc regardless of how the PathDiagnosticLocation was specified? (PathDiagnosticLocation::asLocation).


On May 22, 2013, at 11:52 , Ted Kremenek <kremenek at apple.com> wrote:

> +      PathPieces::iterator PieceToErase = I;
> +      ++I;
> +      erased = true;
> +      path.erase(PieceToErase);

This is better written "I = path.erase(I)" (and still "erased = true", of course).

Jordan
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20130522/3f9cf90b/attachment.html>


More information about the cfe-commits mailing list