[PATCH] Enhancements for the DynTypedNode

Samuel Benzaquen sbenza at google.com
Tue May 21 07:36:47 PDT 2013



================
Comment at: include/clang/AST/ASTFwd.h:14
@@ +13,3 @@
+//===-------------------------------------------------------------===//
+
+
----------------
Manuel Klimek wrote:
> Nit: I'd remove the extra newline for symmetry :)
Done.

================
Comment at: include/clang/AST/ASTTypeTraits.h:40
@@ +39,3 @@
+
+  /// \brief Some shortcuts for base types.
+  static DynNodeType decl() { return DynNodeType(NTI_Decl); }
----------------
Manuel Klimek wrote:
> I'd get rid of the shortcut functions - I don't think they buy much, but make the code inconsistent.
Done.


http://llvm-reviews.chandlerc.com/D829



More information about the cfe-commits mailing list